Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust BPF: Xargo does not use toolchain passes when building sysroot or dependent crates #3107

Closed
jackcmay opened this issue Mar 4, 2019 · 1 comment

Comments

@jackcmay
Copy link
Contributor

jackcmay commented Mar 4, 2019

Problem

Would expect the following to build the project, sysroot, and any dependent crates all with the bpf toolchain but it doesn't:

xargo +bpf build

In order to work around this either the default toolchain must be set to bpf:

rustup default bpf

Or local directory override must be set:

rustup override set bpf

Proposed Solution

Xargo should propagate the passed toolchain for everything it builds.

@mvines mvines added this to the The Future! milestone Apr 8, 2019
@jackcmay
Copy link
Contributor Author

Already raised for xargo: japaric/xargo#123

Our workaround is to use the RUSTUP_TOOLCHAIN environment variable.

brooksprumo pushed a commit to brooksprumo/solana that referenced this issue Oct 8, 2024
* build(deps): bump proc-macro2 from 1.0.86 to 1.0.87

Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.86 to 1.0.87.
- [Release notes](https://github.com/dtolnay/proc-macro2/releases)
- [Commits](dtolnay/proc-macro2@1.0.86...1.0.87)

---
updated-dependencies:
- dependency-name: proc-macro2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update all Cargo files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants