Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

ncp::tests::test_exit breaks CI #328

Closed
garious opened this issue Jun 7, 2018 · 1 comment
Closed

ncp::tests::test_exit breaks CI #328

garious opened this issue Jun 7, 2018 · 1 comment
Assignees
@aeyakovenko
Milestone
v0.7.0

Comments

@garious
Copy link
Contributor

garious commented Jun 7, 2018 •
edited
Loading

ncp::tests::test_exit causes CI to fail in coverage ~50% of the time. Should it be moved to the integration test suite?
@garious garious added this to the v0.7.0 milestone Jun 7, 2018
@garious garious changed the title data_replicator::tests::test_exit breaks CI ncp::tests::test_exit breaks CI Jun 8, 2018
@garious
Copy link
Contributor Author

garious commented Jun 11, 2018

@aeyakovenko says he ran it outside code coverage in a tight loop with no problems and would prefer not move it to the integration test because the coverage instrumentation is broken.

@aeyakovenko aeyakovenko mentioned this issue Jun 13, 2018
Merged
yhchiang-sol pushed a commit to yhchiang-sol/solana that referenced this issue Mar 20, 2024
@tao-stones
qos service should also accumulate executed but errored units (solana…
184ba6c 
…-labs#328)

qos service should also accumulated executed but errored units
willhickey pushed a commit that referenced this issue Mar 20, 2024
@tao-stones @willhickey
qos service should also accumulate executed but errored units (#328)
0119437 
qos service should also accumulated executed but errored units
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeyakovenko aeyakovenko

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
2 participants
@garious @aeyakovenko