This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add Ledger error codes #10056
Merged
solana-grimes
merged 4 commits into
solana-labs:master
from
CriesofCarrots:ledger-error-codes
May 15, 2020
Merged
Add Ledger error codes #10056
solana-grimes
merged 4 commits into
solana-labs:master
from
CriesofCarrots:ledger-error-codes
May 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
May 15, 2020
garious
reviewed
May 15, 2020
CriesofCarrots
commented
May 15, 2020
CriesofCarrots
force-pushed
the
ledger-error-codes
branch
from
May 15, 2020 03:17
b055cc5
to
9d68783
Compare
t-nelson
approved these changes
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I need to hunt up a couple of these that weren't explicitly THROW()
n 🤔
This side looks good to me though!
garious
approved these changes
May 15, 2020
@garious , would you like this on v1.1? |
Yes, please |
CriesofCarrots
added
v1.1
automerge
Merge this Pull Request automatically once CI passes
labels
May 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #10056 +/- ##
=========================================
- Coverage 80.5% 80.5% -0.1%
=========================================
Files 295 296 +1
Lines 68157 68201 +44
=========================================
+ Hits 54928 54931 +3
- Misses 13229 13270 +41 |
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2020
automerge (cherry picked from commit 63813fe)
solana-grimes
pushed a commit
that referenced
this pull request
May 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ledger-solana-app throws a number of exception codes that aren't recognized by the solana ledger.rs module, and all get translated to
RemoteWalletError::Protocol("Unknown error")
.Summary of Changes