Abort if the open fd limit cannot be increased #10064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2020
automerge (cherry picked from commit 7080fb9) # Conflicts: # ledger/src/blockstore_db.rs
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2020
automerge (cherry picked from commit 7080fb9) # Conflicts: # ledger/src/blockstore_db.rs
solana-grimes
pushed a commit
that referenced
this pull request
May 15, 2020
solana-grimes
pushed a commit
that referenced
this pull request
May 15, 2020
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we emit an error log when the fd limit can't be increased, the validator/ledger-tool still trucks on and will likely generate an unexpected failure sometime later in execution. Better to fail fast and make the user deal with the issue up front.