Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Fixup deserialize_bs58_transaction #10171

Merged
merged 1 commit into from
May 22, 2020
Merged

Fixup deserialize_bs58_transaction #10171

merged 1 commit into from
May 22, 2020

Conversation

CriesofCarrots
Copy link
Contributor

Problem

Node can panic due to unwrap on bs58::decode of transactions

Summary of Changes

  • Return error instead of unwrap
  • Also change a few invalid_requests to invalid_parameter to be more precise and include error details

@CriesofCarrots CriesofCarrots requested a review from mvines May 21, 2020 21:54
mvines
mvines previously approved these changes May 21, 2020
View reviewed changes
core/src/rpc.rs Show resolved Hide resolved
@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label May 21, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label May 21, 2020
@mergify mergify bot dismissed mvines’s stale review May 21, 2020 22:47

Pull request has been modified.

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label May 22, 2020
@solana-grimes solana-grimes merged commit 12a3b1b into solana-labs:master May 22, 2020
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #10171 into master will increase coverage by 0.0%.
The diff coverage is 80.0%.

@@           Coverage Diff           @@
##           master   #10171   +/-   ##
=======================================
  Coverage    81.4%    81.5%           
=======================================
  Files         283      283           
  Lines       66050    66040   -10     
=======================================
+ Hits        53822    53831    +9     
+ Misses      12228    12209   -19

mergify bot pushed a commit that referenced this pull request May 22, 2020
@CriesofCarrots
Fixup deserialize_bs58_transaction, and make a few error types more t…
8733e82 
…argeted (#10171)

automerge

(cherry picked from commit 12a3b1b)

# Conflicts:
#	core/src/rpc.rs
@mergify mergify bot mentioned this pull request May 22, 2020
Merged
mergify bot pushed a commit that referenced this pull request May 22, 2020
@CriesofCarrots
Fixup deserialize_bs58_transaction, and make a few error types more t…
866ad33 
…argeted (#10171)

automerge

(cherry picked from commit 12a3b1b)

# Conflicts:
#	core/src/rpc.rs
@mergify mergify bot mentioned this pull request May 22, 2020
Merged
CriesofCarrots added a commit that referenced this pull request May 22, 2020
@CriesofCarrots
Fixup deserialize_bs58_transaction, and make a few error types more t…
dc0db92 
…argeted (#10171)

automerge

(cherry picked from commit 12a3b1b)
CriesofCarrots added a commit that referenced this pull request May 22, 2020
@CriesofCarrots
Fixup deserialize_bs58_transaction, and make a few error types more t…
f6104ad 
…argeted (#10171)

automerge

(cherry picked from commit 12a3b1b)
mvines pushed a commit that referenced this pull request May 22, 2020
@mergify @CriesofCarrots
Fixup deserialize_bs58_transaction, and make a few error types more t…
ee1f218 
…argeted (#10171) (#10176)

automerge

(cherry picked from commit 12a3b1b)

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
solana-grimes pushed a commit that referenced this pull request May 22, 2020
@mergify
Fixup deserialize_bs58_transaction, and make a few error types more t…
ccfe09e 
…argeted (#10171) (#10177)

automerge
@CriesofCarrots CriesofCarrots deleted the decode-tx-unwrap branch May 26, 2020 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvines mvines mvines left review comments

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CriesofCarrots @solana-grimes @mvines