This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
ledger_cleanup_service: compact at a slower rate than purging #10414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sakridge - still testing this on a couple nodes but wdyt? |
sakridge
reviewed
Jun 4, 2020
Looks good, just the comment about epochs. |
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #10414 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 295 295
Lines 69154 69175 +21
=======================================
+ Hits 56448 56476 +28
+ Misses 12706 12699 -7 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2020
(cherry picked from commit aa68329)
solana-grimes
pushed a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to compact after each purge and doing so significantly increases disk IOPS. Instead take the compaction hit once an epoch.
On testnet.solana.com this drops IOPS from a solid 50 MB/s read/write by an order of magnitude, with a 10x IOPS hit every couple days for ~20 min for compaction