-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy cleanup for all targets and nighly rust (also support 1.44.0) #10445
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10445 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 296 296
Lines 69340 69320 -20
=========================================
- Hits 56646 56620 -26
- Misses 12694 12700 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svenski123 Thank you so much for working on these cleaning ups yet more again!!
So far, very good! Could you check my some comments and rebase to fix the conflicts?
minor refactoring in: - cli/src/cli.rs - cli/src/offline/blockhash_query.rs - logger/src/lib.rs - runtime/src/accounts_db.rs expect some performance improvement AccountsDB::clean_accounts()
replace ref-to-arc with ref parameters where arc not cloned
bd9fae9
to
e7cd6df
Compare
@@ -245,7 +248,8 @@ mod tests { | |||
let key = Keypair::new(); | |||
let index = AccountsIndex::<bool>::default(); | |||
let ancestors = HashMap::new(); | |||
assert!(index.get(&key.pubkey(), &ancestors).is_none()); | |||
assert!(index.get(&key.pubkey(), Some(&ancestors)).is_none()); | |||
assert!(index.get(&key.pubkey(), None).is_none()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice for adding another case for your change. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! Thanks for working on this!
This pr was the basis for #10585 . |
Problem
Further clippy warning edits, this time for all targets and against rust 1.45.0 (nightly)
Summary of Changes
rustup run nightly cargo clippy --workspace --all-targets
References