Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Run clippy with a workaround to avoid being skipped #10464

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Run clippy with a workaround to avoid being skipped #10464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53a6cb7
Run clippy before check to avoid being skipped
ryoqun Jun 9, 2020
092e5df
Tweak output
ryoqun Jun 9, 2020
04d09c3
Apply a workaround
ryoqun Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ci/test-checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@ if _ scripts/cargo-for-all-lock-files.sh +"$rust_nightly" check --locked --all-t
else
check_status=$?
echo "Some Cargo.lock is outdated; please update them as well"
echo "protip: you can use ./scripts/cargo-for-all-lock-files.sh update ..."
echo "protip: you can use ./scripts/cargo-for-all-lock-files.sh [check|update] ..."
exit "$check_status"
fi

_ cargo +"$rust_stable" fmt --all -- --check

_ cargo +"$rust_nightly" clippy --version
_ cargo +"$rust_nightly" clippy --workspace --all-targets -- --deny=warnings
# -Z... is needed because of clippy bug: https://github.com/rust-lang/rust-clippy/issues/4612
_ cargo +"$rust_nightly" clippy -Zunstable-options --version
_ cargo +"$rust_nightly" clippy -Zunstable-options --workspace --all-targets -- --deny=warnings
Comment on lines +27 to +29
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here


_ cargo +"$rust_stable" audit --version
_ scripts/cargo-for-all-lock-files.sh +"$rust_stable" audit --ignore RUSTSEC-2020-0002 --ignore RUSTSEC-2020-0008
Expand Down
3 changes: 3 additions & 0 deletions scripts/cargo-for-all-lock-files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ else
fi

for lock_file in $files; do
if [[ -n $CI ]]; then
echo "--- [$lock_file]: cargo " "${shifted_args[@]}" "$@"
fi
(
set -x
cd "$(dirname "$lock_file")"
Expand Down