More refactoring #115
More refactoring #115
Conversation
And remove redundant into_iter() calls.
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 95.54% 95.68% +0.14%
==========================================
Files 17 17
Lines 1504 1508 +4
==========================================
+ Hits 1437 1443 +6
+ Misses 67 65 -2
Continue to review full report at Codecov.
|
| .zip(vers) | ||
| .filter_map(|(req, ver)| req.map(|(msg, addr)| (msg, addr, ver))) | ||
| .filter(|x| x.0.verify()) | ||
| .collect(); |
There was a problem hiding this comment.
this is going to be one big alloc
There was a problem hiding this comment.
It's using into_iter(). Should reduce to memmove().
There was a problem hiding this comment.
Vec<Vec<>> into Vec, right? So the output is going to be all of the requests we just pulled up. basically this will kill the improvement we are trying to get with the allocator, since it will allocate all the space for all the IO buffers copy into it, and them drop that buffer later.
There was a problem hiding this comment.
or do you mean its smart enough to know about the into_iter on line 163 and compile the allocation out?
Bumps [jayson](https://github.com/tedeh/jayson) from 3.2.0 to 3.3.3. - [Release notes](https://github.com/tedeh/jayson/releases) - [Commits](tedeh/jayson@v3.2.0...v3.3.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Following commits will use this api to check retransmitter's signature on incoming shreds.
…ree (backport of solana-labs#115) (solana-labs#135) adds api to obtain the parent node in the turbine retransmit tree (solana-labs#115) Following commits will use this api to check retransmitter's signature on incoming shreds. (cherry picked from commit 42e8309) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Working towards filtering messages before deserialization. Currently, the messages need to be deserialized because the sig-verified bit is only defined for Transaction messages.