Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rust to 1.47.0 #12739

Closed
wants to merge 8 commits into from
Closed

Bump rust to 1.47.0 #12739

wants to merge 8 commits into from

Conversation

t-nelson
Copy link
Contributor

@t-nelson t-nelson commented Oct 8, 2020

Problem

We aren't using the latest stable Rust!

Summary of Changes

  • Bump stable to 1.47.0, nightly to 2020-10-05
  • Fix clippy and fmt

@t-nelson t-nelson added the v1.4 label Oct 8, 2020
@t-nelson t-nelson requested a review from mvines October 8, 2020 22:21
t-nelson
t-nelson commented Oct 8, 2020
View reviewed changes
runtime/src/bank.rs
Self::new(&GenesisConfig::default())
}
}

Copy link
Contributor Author

@t-nelson t-nelson Oct 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a safe move. Bank::default() seemed to only be used in tests/benches and the derive was making the changes of feature_builtins to Arc<[(Builtin, Pubkey)]> a PITA since Entrypoint has no sane default value.

t-nelson
t-nelson commented Oct 8, 2020
View reviewed changes
ci/test-checks.sh
@@ -54,8 +54,7 @@ _ cargo +"$rust_stable" fmt --all -- --check
# -Z... is needed because of clippy bug: https://github.com/rust-lang/rust-clippy/issues/4612
# run nightly clippy for `sdk/` as there's a moderate amount of nightly-only code there
_ cargo +"$rust_nightly" clippy \
-Zunstable-options --workspace --all-targets \
-- --deny=warnings --allow=clippy::stable_sort_primitive
-Zunstable-options --workspace --all-targets -- --deny=warnings
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and popped --allow=clippy::stable_sort_primitive out here, since stable enforces it now

t-nelson
t-nelson commented Oct 8, 2020
View reviewed changes
sys-tuner/src/main.rs
@@ -149,10 +149,6 @@ fn main() {
for stream in listener.incoming() {
if stream.is_ok() {
info!("Tuning the system now");
#[cfg(target_os = "linux")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/rustfmt#4452 (comment)

@t-nelson t-nelson force-pushed the bump-rust-to-1.47.0 branch from f4accae to 99948e9 Compare October 9, 2020 05:43
@ryoqun ryoqun mentioned this pull request Oct 9, 2020
Merged
@t-nelson t-nelson marked this pull request as draft October 12, 2020 14:44
@t-nelson
Copy link
Contributor Author

Converting this to draft while I figure out which of the clippy "fixes" is blowing the thread stack during tests. Repros on 1.46, so I don't suspect the compiler just yet.

@t-nelson t-nelson force-pushed the bump-rust-to-1.47.0 branch from 99948e9 to 7b06cc4 Compare October 13, 2020 03:51
@t-nelson t-nelson added the noCI Suppress CI on this Pull Request label Oct 13, 2020
@t-nelson t-nelson marked this pull request as ready for review October 13, 2020 03:52
@t-nelson
Copy link
Contributor Author

Converting this to draft while I figure out which of the clippy "fixes" is blowing the thread stack during tests. Repros on 1.46, so I don't suspect the compiler just yet.

Haha! Recursive Default impl go brrrrrrr

Just blocked on an spl-token with solana crates bumped

@stale
Copy link

stale bot commented Oct 20, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 20, 2020
@t-nelson t-nelson removed the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 20, 2020
@stale
Copy link

stale bot commented Oct 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 28, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Nov 5, 2020
@t-nelson t-nelson removed the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 5, 2020
@t-nelson t-nelson reopened this Nov 5, 2020
@stale
Copy link

stale bot commented Nov 13, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 13, 2020
@t-nelson t-nelson removed the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 13, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 21, 2020
@stale
Copy link

stale bot commented Nov 28, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Nov 28, 2020
@t-nelson t-nelson deleted the bump-rust-to-1.47.0 branch December 30, 2020 03:07
This was referenced Sep 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvines mvines Awaiting requested review from mvines

Assignees
No one assigned
Labels
noCI Suppress CI on this Pull Request stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-nelson