Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Inclusion Proposal #12936

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Conversation

carllin
Copy link
Contributor

@carllin carllin commented Oct 16, 2020

Problem

No way for light clients to independently verify a transaction was optimistically confirmed

Summary of Changes

Fixes #

@carllin carllin force-pushed the LightClientProposal branch 3 times, most recently from 650d961 to 5cb16ce Compare October 16, 2020 02:09
@t-nelson
Copy link
Contributor

Mind wrapping at 80 char to ease review? 🙏

@carllin carllin force-pushed the LightClientProposal branch 2 times, most recently from 8595640 to 7879887 Compare October 16, 2020 04:32
@@ -151,7 +151,8 @@ fn main() {
info!("Tuning the system now");
#[cfg(target_os = "linux")]
{
// tune_poh_service_priority(peer_uid);
[cfg(target_os = "linux")]
Copy link
Member

@ryoqun ryoqun Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: @carllin oh again? ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe darn! yeah

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carllin carllin force-pushed the LightClientProposal branch from 7879887 to dc42c5d Compare October 16, 2020 04:56
@carllin
Copy link
Contributor Author

carllin commented Oct 16, 2020

@t-nelson wrapped!

t-nelson
t-nelson previously approved these changes Oct 16, 2020
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions look good and jive with my mental model of what needs to happen.

One nit. You may want to replace the GH links that target master with ones targeting a specific commit. The linked code blocks will drift otherwise.

@carllin
Copy link
Contributor Author

carllin commented Oct 17, 2020

@t-nelson yup, updated!

@mergify mergify bot dismissed t-nelson’s stale review October 17, 2020 01:16

Pull request has been modified.

@carllin carllin force-pushed the LightClientProposal branch from e0b5cc4 to 8926210 Compare October 17, 2020 01:23
@carllin carllin merged commit 8aecea6 into solana-labs:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants