Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Workaround linux hang #137

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Workaround linux hang #137

merged 1 commit into from
Apr 19, 2018

Conversation

garious
Copy link
Contributor

@garious garious commented Apr 19, 2018

Without this patch, Linux systems would hang when running the demo.

The root cause (why Linux is acting differently than macOS) was
not determined, but we know the problem is caused by a known
issue in the transaction pipeline - that entries are not pulled
off the historian channel until after the full transaction batch
is processed. This patch makes the sync_channel large enough that
it should never block on a gigabit network.

Without this patch, Linux systems would hang when running the demo.

The root cause (why Linux is acting differently than macOS) was
not determined, but we know the problem is caused by a known
issue in the transaction pipeline - that entries are not pulled
off the historian channel until after the full transaction batch
is processed. This patch makes the sync_channel large enough that
it should never block on a gigabit network.
@garious garious requested review from sakridge and aeyakovenko April 19, 2018 17:13
@garious
Copy link
Contributor Author

garious commented Apr 19, 2018

@rlkelly, fyi

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          18       18           
  Lines        1886     1886           
=======================================
  Hits         1818     1818           
  Misses         68       68
Impacted Files Coverage Δ
src/historian.rs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e6741...c6048e2. Read the comment docs.

Copy link
Contributor

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garious garious merged commit 10a0c47 into solana-labs:master Apr 19, 2018
steviez added a commit to steviez/solana that referenced this pull request Mar 8, 2024
…abs#137)

ReplayStage owning the pool allows for subsequent work to configure
the size of the pool; configuring the size of the pool inside of the
lazy_static would have been a little messy
willhickey pushed a commit that referenced this pull request Mar 9, 2024
ReplayStage owning the pool allows for subsequent work to configure
the size of the pool; configuring the size of the pool inside of the
lazy_static would have been a little messy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants