This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
No longer allow unauthorized keys to witness transactions #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, an attacker could point Budget instructions to unsigned keys, and authorize a transaction from an unauthorized party.
mvines
approved these changes
Oct 19, 2018
aeyakovenko
approved these changes
Oct 19, 2018
|
Yes, when you implement this #1551, that new code should call |
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Jun 4, 2024
…solana-labs#1550) re-export grouped ciphertext validity proof data and context
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, an attacker could point Budget instructions to unsigned keys, and authorize a transaction from an unauthorized party. This patch adds a new
signed_keymethod toTransactionthat allows programs to lookup only signed keys. Currently, that implies key zero, but oncesignature: SignaturebecomesVec<Signature>, the method will allow a program to safely use any key in that vector.