This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix: compute pre/post token balances on all accounts if token program present #15900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15900 +/- ##
=======================================
Coverage 80.0% 80.0%
=======================================
Files 409 409
Lines 106417 106415 -2
=======================================
+ Hits 85182 85198 +16
+ Misses 21235 21217 -18 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SPL Token balance changes from inner instructions are not included in {pre,post}TokenBalances.
Summary of Changes
Previously, account balance queries were performed only if token program was involved at the instruction level. This change queries all accounts when the token program is present in the transaction.
Fixes #15760