This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
rpc: Add config options limiting getConfirmedBlock response data #15970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
gcb-options
branch
from
3b0575d to
5ab0455
Compare
mvines
previously approved these changes
Mar 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #15970 +/- ##
=========================================
- Coverage 79.9% 79.9% -0.1%
=========================================
Files 409 409
Lines 107203 107299 +96
=========================================
+ Hits 85698 85752 +54
- Misses 21505 21547 +42 |
CriesofCarrots
force-pushed
the
gcb-options
branch
from
ab9b359 to
53d1a5c
Compare
CriesofCarrots
force-pushed
the
gcb-options
branch
from
53d1a5c to
3b10f62
Compare
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2021
) * Add new confirmed block struct * Add RpcConfirmedBlockConfig options * Configure block response based on new options * Add client api, use in cli fetch_epoch_rewards * Update docs * Apply review suggestions (cherry picked from commit aa54c46) # Conflicts: # core/src/rpc.rs
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2021
) * Add new confirmed block struct * Add RpcConfirmedBlockConfig options * Configure block response based on new options * Add client api, use in cli fetch_epoch_rewards * Update docs * Apply review suggestions (cherry picked from commit aa54c46)
mergify bot
added a commit
that referenced
this pull request
Mar 18, 2021
) (#15995) * Add new confirmed block struct * Add RpcConfirmedBlockConfig options * Configure block response based on new options * Add client api, use in cli fetch_epoch_rewards * Update docs * Apply review suggestions (cherry picked from commit aa54c46) Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
mergify bot
added a commit
that referenced
this pull request
Mar 18, 2021
…15970) (#15994) * rpc: Add config options limiting getConfirmedBlock response data (#15970) * Add new confirmed block struct * Add RpcConfirmedBlockConfig options * Configure block response based on new options * Add client api, use in cli fetch_epoch_rewards * Update docs * Apply review suggestions (cherry picked from commit aa54c46) # Conflicts: # core/src/rpc.rs * Fix conflicts Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
getConfirmedBlockRPC response can be quite massive when considering transaction details and metadata as well as a ton of reward information for blocks on the epoch boundary. Not all consumers will need this information but currently everyone has to pay the cost of bandwidth and response time.Summary of Changes
RpcConfirmedBlockConfigto support different levels of transaction details: all, signatures, or noneRpcConfirmedBlockConfigto allow suppressing reward infoEncodedConfirmedBlockare still supported.Fixes #15817