This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Rpc: make getStakeActivation response consistent for undelegated accounts #16038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16038 +/- ##
=======================================
Coverage 79.9% 79.9%
=======================================
Files 409 409
Lines 107685 107692 +7
=======================================
+ Hits 86102 86127 +25
+ Misses 21583 21565 -18 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For inactive epochs of a stake account, the
getStakeActivationendpoint returns a different response when a stake account has never been delegated vs when it has.Summary of Changes
Make consistent. If the stake account exists but is not yet delegated, return the same
inactiveRpcStakeActivation as if the account had been delegated and immediately deactivated.Fixes #16021