Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Status cache improvements #16174

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

sakridge
Copy link
Contributor

Problem

StatusCache is too specific and the get_status names could be tweaked.

Summary of Changes

StatusCache improvements.

Fixes #

@sakridge sakridge requested a review from t-nelson March 28, 2021 18:53
@sakridge sakridge force-pushed the status-cache branch 3 times, most recently from dfaa155 to e79a113 Compare March 28, 2021 19:13
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #16174 (141de50) into master (16e4ccc) will increase coverage by 0.0%.
The diff coverage is 97.3%.

@@           Coverage Diff           @@
##           master   #16174   +/-   ##
=======================================
  Coverage    80.0%    80.0%           
=======================================
  Files         410      410           
  Lines      109447   109448    +1     
=======================================
+ Hits        87657    87658    +1     
  Misses      21790    21790           

@sakridge sakridge requested a review from carllin March 29, 2021 00:01
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sakridge sakridge added the v1.6 label Mar 29, 2021
@sakridge sakridge merged commit 5e5b637 into solana-labs:master Mar 29, 2021
@sakridge sakridge deleted the status-cache branch March 29, 2021 02:10
mergify bot pushed a commit that referenced this pull request Mar 29, 2021
(cherry picked from commit 5e5b637)
sakridge added a commit that referenced this pull request Mar 29, 2021
(cherry picked from commit 5e5b637)

Co-authored-by: sakridge <sakridge@gmail.com>
@jstarry jstarry added the v1.5 label Apr 13, 2021
mergify bot pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 5e5b637)

# Conflicts:
#	runtime/src/bank.rs
#	runtime/src/status_cache.rs
jstarry pushed a commit that referenced this pull request Apr 13, 2021
mergify bot added a commit that referenced this pull request Apr 13, 2021
Co-authored-by: sakridge <sakridge@gmail.com>
@jstarry
Copy link
Contributor

jstarry commented Apr 13, 2021

FYI @sakridge I ported this change to v1.5

@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants