This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
status-cache
branch
3 times, most recently
from
March 28, 2021 19:13
dfaa155
to
e79a113
Compare
Codecov Report
@@ Coverage Diff @@
## master #16174 +/- ##
=======================================
Coverage 80.0% 80.0%
=======================================
Files 410 410
Lines 109447 109448 +1
=======================================
+ Hits 87657 87658 +1
Misses 21790 21790 |
t-nelson
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
(cherry picked from commit 5e5b637)
sakridge
added a commit
that referenced
this pull request
Mar 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
(cherry picked from commit 5e5b637) # Conflicts: # runtime/src/bank.rs # runtime/src/status_cache.rs
jstarry
pushed a commit
that referenced
this pull request
Apr 13, 2021
FYI @sakridge I ported this change to v1.5 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
StatusCache is too specific and the get_status names could be tweaked.
Summary of Changes
StatusCache improvements.
Fixes #