This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Allow fork choice to support multiple versions of a slot #16266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16266 +/- ##
========================================
Coverage 80.1% 80.2%
========================================
Files 413 413
Lines 110490 111187 +697
========================================
+ Hits 88558 89212 +654
- Misses 21932 21975 +43 |
carllin
force-pushed
the
FixReplayStage
branch
10 times, most recently
from
beba884 to
e741e3b
Compare
carllin
force-pushed
the
FixReplayStage
branch
2 times, most recently
from
e9bcc27 to
ca060b2
Compare
jstarry
reviewed
Apr 9, 2021
carllin
force-pushed
the
FixReplayStage
branch
3 times, most recently
from
a892a6c to
e9c5b60
Compare
jstarry
reviewed
Apr 11, 2021
jstarry
previously approved these changes
Apr 11, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 12, 2021
(cherry picked from commit dc7030f)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fork choice doesn't track separate sets of votes if validators vote on one version of a slot, dump it, then repair another version
Summary of Changes
Add support for tracking multiple versions of slots in fork choice
TODO: Figure out best way to handle the case described here: 153aaa2#diff-0bd0e50030bdee14082c678da5f3098df8156825fa86c59ad55ddbd2a3669585R92-R119
Fixes #