This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
issue #10831: added --with-memo option to all cli commands that submit #16291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that submit transactions. Also, improve the block command to show UTF-8 string instead of integer values for memo program data.
t-nelson
reviewed
Apr 1, 2021
t-nelson
reviewed
Apr 1, 2021
|
@bji - I sent you a github invite for contributor access to the repo, if you accept then we don't need to continually add the CI flag to your PR anymore |
mvines
added
CI
|
Can someone explain this Cargo.lock issue? I had to use the spl-memo package and this resulted in the cargo build command updating Cargo.lock. Isn't Cargo.lock a generated file? If so, why is it even checked into the repo? |
Merged
CriesofCarrots
approved these changes
Apr 5, 2021
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2021
#16291) * issue #10831: added --with-memo option to all cli commands that submit transactions. Also, improve the block command to show UTF-8 string instead of integer values for memo program data. * Fixed tests and changed some syntax according to feedback. * Use spl_memo id (all versions where applicable) instead of hardcoding id. * Update Cargo.toml in programs/bpf. * Update formatting via cargo fmt. * Update to use spl_memo version 3.0.1, which simplifies package imports (cherry picked from commit 364af3a) # Conflicts: # cli-output/Cargo.toml # cli-output/src/display.rs # cli/Cargo.toml # cli/tests/transfer.rs
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2021
#16291) * issue #10831: added --with-memo option to all cli commands that submit transactions. Also, improve the block command to show UTF-8 string instead of integer values for memo program data. * Fixed tests and changed some syntax according to feedback. * Use spl_memo id (all versions where applicable) instead of hardcoding id. * Update Cargo.toml in programs/bpf. * Update formatting via cargo fmt. * Update to use spl_memo version 3.0.1, which simplifies package imports (cherry picked from commit 364af3a) # Conflicts: # cli-output/Cargo.toml # cli/Cargo.toml
mergify bot
added a commit
that referenced
this pull request
Apr 5, 2021
…t (bp #16291) (#16387) * issue #10831: added --with-memo option to all cli commands that submit (#16291) * issue #10831: added --with-memo option to all cli commands that submit transactions. Also, improve the block command to show UTF-8 string instead of integer values for memo program data. * Fixed tests and changed some syntax according to feedback. * Use spl_memo id (all versions where applicable) instead of hardcoding id. * Update Cargo.toml in programs/bpf. * Update formatting via cargo fmt. * Update to use spl_memo version 3.0.1, which simplifies package imports (cherry picked from commit 364af3a) # Conflicts: # cli-output/Cargo.toml # cli/Cargo.toml * Fix conflicts Co-authored-by: bji <bryan@ischo.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transactions. Also, improve the block command to show UTF-8 string instead
of integer values for memo program data.
Problem
There was no way previously to add a memo to transactions via the cli.
Summary of Changes
Added memo support and additionally ensured that memo data is displayed as UTF-8 string instead of raw data in the cli block command
Fixes #10831