This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Remove unprocessed transactions from log notifications #16349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16349 +/- ##
=========================================
- Coverage 80.1% 80.1% -0.1%
=========================================
Files 411 411
Lines 110147 110148 +1
=========================================
Hits 88265 88265
- Misses 21882 21883 +1 |
mvines
approved these changes
Apr 4, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2021
(cherry picked from commit 0596cf5)
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2021
(cherry picked from commit 0596cf5)
mvines
pushed a commit
that referenced
this pull request
Apr 4, 2021
(cherry picked from commit 0596cf5)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Log subscriptions are sent notifications for non-processing related transaction errors which are not valuable to the client. This commonly includes "AccountInUse" errors because even transactions which don't obtain account locks are being iterated over when sending log notifications. This is causing unexpected error types as reported in this issue: solana-labs/solana-web3.js#1019
Summary of Changes
Only notify log events for transactions that were processed
Fixes #16339