This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
RpcClient no longer panics in a tokio multi-threaded runtime #16385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
commented
Apr 5, 2021
| let request_id = 1; | ||
|
|
||
| let request_json = request.build_request_json(request_id, params); | ||
| let request_id = self.request_id.fetch_add(1, Ordering::Relaxed); |
mvines
commented
Apr 5, 2021
|
|
||
| #[tokio::test(flavor = "current_thread")] | ||
| #[should_panic(expected = "can call blocking only when running on the multi-threaded runtime")] | ||
| async fn http_sender_ontokio_current_thread_should_panic() { |
There was a problem hiding this comment.
This isn't great, but I don't see a way around. Fortunately [tokio::main] creates a multi_thread runtime, so most users won't see this (but #[tokio::test], sans flavour, is current_thread)
There was a problem hiding this comment.
I see, obv not ideal but okay for now. I haven't thought of anything better.
CriesofCarrots
approved these changes
Apr 5, 2021
|
|
||
| #[tokio::test(flavor = "current_thread")] | ||
| #[should_panic(expected = "can call blocking only when running on the multi-threaded runtime")] | ||
| async fn http_sender_ontokio_current_thread_should_panic() { |
There was a problem hiding this comment.
I see, obv not ideal but okay for now. I haven't thought of anything better.
Codecov Report
@@ Coverage Diff @@
## master #16385 +/- ##
=======================================
Coverage 80.1% 80.1%
=======================================
Files 411 411
Lines 110155 110194 +39
=======================================
+ Hits 88268 88366 +98
+ Misses 21887 21828 -59 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-tokio 1 upgrade (Solana 1.6.2),
RpcClientwould panic if run from within a tokio runtime. Fix it by shuttling the blocking requests off to a different tokio threadOne glorious day we'll have an async RpcClient (blocked on the jsonrpc crates turning into jsonrpsee crates for a tokio 1 update here), after which we can autogen the RpcClient bindings. For now
RpcClientworking in async is better than nothing though.