This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
[easy, cleanup] Simplify some pattern-matches #16402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
added
CI
mvines
reviewed
Apr 6, 2021
|
Cool tool @huitseeker! |
When those match an exact combinator on Option / Result. Tool-aided by [comby-rust](https://github.com/huitseeker/comby-rust).
Codecov Report
@@ Coverage Diff @@
## master #16402 +/- ##
=======================================
Coverage 80.0% 80.0%
=======================================
Files 413 413
Lines 110592 110560 -32
=======================================
- Hits 88559 88543 -16
+ Misses 22033 22017 -16 |
|
Thanks for the tidy up and sharing your tool, @huitseeker ! |
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2021
When those match an exact combinator on Option / Result. Tool-aided by [comby-rust](https://github.com/huitseeker/comby-rust). (cherry picked from commit b08cff9) # Conflicts: # accounts-cluster-bench/src/main.rs # core/src/rpc.rs # runtime/src/accounts_hash.rs # runtime/src/message_processor.rs
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2021
When those match an exact combinator on Option / Result. Tool-aided by [comby-rust](https://github.com/huitseeker/comby-rust). (cherry picked from commit b08cff9)
mergify bot
added a commit
that referenced
this pull request
Apr 8, 2021
* Simplify some pattern-matches (#16402) When those match an exact combinator on Option / Result. Tool-aided by [comby-rust](https://github.com/huitseeker/comby-rust). (cherry picked from commit b08cff9) # Conflicts: # accounts-cluster-bench/src/main.rs # core/src/rpc.rs # runtime/src/accounts_hash.rs # runtime/src/message_processor.rs * Fix conflicts Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
mergify bot
added a commit
that referenced
this pull request
Apr 8, 2021
When those match an exact combinator on Option / Result. Tool-aided by [comby-rust](https://github.com/huitseeker/comby-rust). (cherry picked from commit b08cff9) Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When those match an exact combinator on Option / Result.
Tool-aided by comby-rust.