This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Track gossip vote updates per hash for replay stage #16421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16421 +/- ##
=========================================
- Coverage 80.1% 80.1% -0.1%
=========================================
Files 413 413
Lines 110490 110550 +60
=========================================
+ Hits 88558 88606 +48
- Misses 21932 21944 +12 |
sakridge
approved these changes
Apr 10, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2021
* Track gossip vote updates per hash for replay stage (cherry picked from commit 99b3aab) # Conflicts: # core/src/consensus.rs # core/src/replay_stage.rs
carllin
added a commit
that referenced
this pull request
Apr 11, 2021
* Track gossip vote updates per hash for replay stage (cherry picked from commit 99b3aab)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fork choice and switching votes from replay stage should include votes observed in gossip
Summary of Changes
First step, add ability in cluster info vote listener to track new votes by hash
fyi @aeyakovenko
Fixes #