This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
solana validators now shows current epoch credits instead of lifetime credits
#16635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16635 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 415 415
Lines 114705 114705
=========================================
- Hits 95275 95269 -6
- Misses 19430 19436 +6 |
|
@mvines This is a breaking change for me. Can you get this into both v1.5 & v1.6 at the same time? That way I won't need conditional logic in validators.app |
Oh thanks! Would you prefer that I back this out? Or enable lifetime credits with a flag? Otherwise sure I can backport to v1.5. Does #16639 cause you any concern? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifetime credits are a fun factoid that nobody really cares about. What you really care about is the credits earned in the current epoch, as this is what influences staking rewards.