RPC: use finalized as default pubsub commitment level

[jstarry]

Problem

The default commitment for pubsub and http requests are different which can cause consistency issues in downstream clients.

Summary of Changes

Change the default commitment of pubsub subscriptions from confirmed to finalized

Fixes #16596

[mvines]

Minor wrinkle here I guess is that we explicitly document the default as "confirmed" :-/
https://github.com/solana-labs/solana/search?q=%22For+subscriptions%2C+if+commitment+is+unspecified%2C+the+default+value+is%22

I think it's fair to call this a bug, but it should be called out as a breaking change in the release notes. Does web3.js have anything to say about the default in comments anywhere?

[jstarry]

Minor wrinkle here I guess is that we explicitly document the default as "confirmed" :-/

Dang, will fix

I think it's fair to call this a bug, but it should be called out as a breaking change in the release notes.

Agreed on both points

Does web3.js have anything to say about the default in comments anywhere?

Nope, it even specifies that the "max" is the default here: https://solana-labs.github.io/solana-web3.js/modules.html#sendandconfirmtransaction

[mergify]

automerge label removed due to a CI failure

Pull request has been modified.

[codecov]

Codecov Report

Merging #16659 (77abffa) into master (01786f6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #16659   +/-   ##
=======================================
  Coverage    83.0%    83.0%           
=======================================
  Files         415      415           
  Lines      114995   115000    +5     
=======================================
+ Hits        95475    95480    +5     
  Misses      19520    19520