This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Make metrics tests independent of RUST_LOG environment variable (backport #16710) #16730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Previously, running the tests with RUST_LOG=none would fail, because the env logger would set its filter level to reject all log messages, and incrementing a counter only happens if the global logger has at least the specified log level. Having the tests behave differently when RUST_LOG is set is surprising, they should be self-contained. Nix' buildRustPackage sets RUST_LOG="" to make the build logs less verbose. I have trouble packaging Solana for Nix because of this, and I believe making the tests independent of the environment is a good solution for this. (cherry picked from commit 3f92abe)
mergify
bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.6 #16730 +/- ##
=======================================
Coverage 82.9% 82.9%
=======================================
Files 414 414
Lines 113979 113979
=======================================
+ Hits 94520 94538 +18
+ Misses 19459 19441 -18 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #16710 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/