This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
validates gossip addresses before sending pull-requests #16748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
more-ping-pong
branch
2 times, most recently
from
11937f5 to
dff911b
Compare
Codecov Report
@@ Coverage Diff @@
## master #16748 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 416 416
Lines 116948 116698 -250
=========================================
- Hits 96831 96605 -226
+ Misses 20117 20093 -24 |
behzadnouri
force-pushed
the
more-ping-pong
branch
5 times, most recently
from
914a73a to
4d29505
Compare
behzadnouri
force-pushed
the
more-ping-pong
branch
2 times, most recently
from
2e01b3b to
14d1f8a
Compare
behzadnouri
force-pushed
the
more-ping-pong
branch
from
14d1f8a to
4f81c7d
Compare
IP addresses need to be validated before sending packets to them. This commit, sends a ping packet to nodes before any pull requests. Pull requests are then only sent to the nodes which have responded with the correct hash of their respective ping packet.
behzadnouri
force-pushed
the
more-ping-pong
branch
from
4f81c7d to
72292a6
Compare
mergify bot
added a commit
that referenced
this pull request
May 3, 2021
) (#17009) * uses Mutex instead of RwLock for ping_cache (cherry picked from commit 2231017) * validates gossip addresses before sending pull-requests IP addresses need to be validated before sending packets to them. This commit, sends a ping packet to nodes before any pull requests. Pull requests are then only sent to the nodes which have responded with the correct hash of their respective ping packet. (cherry picked from commit 7cea2c4) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ip addresses need to be validated before sending packets to them.
Summary of Changes