This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rpc: Rework getLeaderSchedule options
#16749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
(cherry picked from commit 636b598)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The parameters in
getLeaderScheduleare not truly optional. In order to usecommitmentoridentity, a slot must be provided.Summary of Changes
Rework
getLeaderScheduleoptions so that slot is truly optional, even with config options includedFixes #16723 (comment)