This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
moves cluster-info metrics to a separate module #16883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16883 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 415 416 +1
Lines 116040 116040
=========================================
- Hits 96065 96062 -3
- Misses 19975 19978 +3 |
carllin
previously approved these changes
Apr 27, 2021
behzadnouri
force-pushed
the
cluster-info-metrics
branch
from
791481d to
fa6fa93
Compare
behzadnouri
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
(cherry picked from commit b17d5ee)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
too much boilerplate code in cluster_info.rs
Summary of Changes
moved metrics code to a separate file.