This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Move Signer types out of the signature module
#17099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
changed the title
Signer types out of the signature module
Sure! Seems like as good a time as any |
t-nelson
force-pushed
the
sdk-breakup-sig-mod
branch
2 times, most recently
from
a23a008 to
18c7db7
Compare
CriesofCarrots
previously approved these changes
May 8, 2021
t-nelson
force-pushed
the
sdk-breakup-sig-mod
branch
from
18c7db7 to
6a9377d
Compare
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
t-nelson
added
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
t-nelson
force-pushed
the
sdk-breakup-sig-mod
branch
from
6a9377d to
88ed4a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #17099 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 417 421 +4
Lines 117718 117724 +6
=========================================
- Hits 97416 97406 -10
- Misses 20302 20318 +16 |
| } | ||
| /// Fallibly gets the implementor's public key | ||
| fn try_pubkey(&self) -> Result<Pubkey, SignerError>; | ||
| /// Invallibly produces an Ed25519 signature over the provided `message` |
There was a problem hiding this comment.
Hmm, I still see Invallibly here... crossed commits, maybe?
mergify bot
added a commit
that referenced
this pull request
May 11, 2021
…17177) * sdk: Move `Signer` trait to own module (cherry picked from commit af6f3d7) * sdk: Move `Keypair` to `signer` module (cherry picked from commit 0eba6eb) * sdk: Move `Presigner` to `signer` module (cherry picked from commit 12bf6c0) * sdk: Move `NullSigner` to `signer` module (cherry picked from commit b71e4bd) * sdk: Move `signers` module into `signer` module (cherry picked from commit 967840a) * sdk: keypair - drop superfluous iter() (cherry picked from commit dbac387) Co-authored-by: Trent Nelson <trent@solana.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Signertypes cluttering thesignaturemodule.Summary of Changes
Move them to their own modules (preserving legacy use-paths)