Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

SignerSource: rename input scheme to prompt, default to bip44 solana base key (backport #17154) #17159

Merged
merged 1 commit into from
May 11, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 11, 2021

This is an automatic backport of pull request #17154 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

…a base key (#17154)

* Rename ask to prompt

* Default to Solana bip44 base if no derivation-path

* Add SignerSource legacy field, support legacy ASK

* Update docs

* Fix docs: validator current doesn't support uri SignerSources

(cherry picked from commit a5ec3a0)
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #17159 (c4c0c97) into v1.6 (ea3b783) will decrease coverage by 0.0%.
The diff coverage is 60.4%.

@@            Coverage Diff            @@
##             v1.6   #17159     +/-   ##
=========================================
- Coverage    82.7%    82.7%   -0.1%     
=========================================
  Files         418      418             
  Lines      115753   115776     +23     
=========================================
+ Hits        95795    95806     +11     
- Misses      19958    19970     +12     

@mergify mergify bot merged commit a7b2939 into v1.6 May 11, 2021
@mergify mergify bot deleted the mergify/bp/v1.6/pr-17154 branch May 11, 2021 02:43
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant