Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

feat: update api urls #17186

Merged
merged 4 commits into from
May 14, 2021
Merged

Conversation

oJshua
Copy link
Contributor

@oJshua oJshua commented May 12, 2021

Problem

Devnet and testnet URLs have updated to https://api.devnet.solana.com and https://api.testnet.solana.com.

Summary of Changes

Update devnet and testnet URLs to https://api.devnet.solana.com and https://api.testnet.solana.com.

@oJshua oJshua requested a review from mvines May 12, 2021 13:49
@mvines
Copy link
Contributor

mvines commented May 12, 2021

@oJshua - can you update the references under docs/, clap-utils/src/input_validators.rs, and cli-config/src/config.rs as well. There may be a couple other references in the repo as well.

These updates should be backported to v1.6 once we're ready to make this switch to api. as well please

@oJshua oJshua force-pushed the web3/api-url-updates branch from a830067 to 9192074 Compare May 12, 2021 15:53
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #17186 (35356d3) into master (5e642a1) will decrease coverage by 12.1%.
The diff coverage is n/a.

❗ Current head 35356d3 differs from pull request most recent head bdfb664. Consider uploading reports for the commit bdfb664 to get more accurate results

@@             Coverage Diff             @@
##           master   #17186       +/-   ##
===========================================
- Coverage    82.7%    70.6%    -12.2%     
===========================================
  Files         421       29      -392     
  Lines      117903     1872   -116031     
  Branches        0      258      +258     
===========================================
- Hits        97533     1322    -96211     
+ Misses      20370      457    -19913     
- Partials        0       93       +93     

@oJshua
Copy link
Contributor Author

oJshua commented May 12, 2021

@mvines Do you know if the doc translations (zh) get updated dynamically somewhere or I do I need to commit changes there as well?

@mvines
Copy link
Contributor

mvines commented May 12, 2021

@mvines Do you know if the doc translations (zh) get updated dynamically somewhere or I do I need to commit changes there as well?

I think a human does it, somehow. In this case I think you can update directly

@oJshua oJshua added the v1.6 label May 14, 2021
@oJshua oJshua force-pushed the web3/api-url-updates branch from bca9db9 to 402161b Compare May 14, 2021 16:45
@oJshua oJshua force-pushed the web3/api-url-updates branch from 402161b to bdfb664 Compare May 14, 2021 17:12
@oJshua oJshua added the CI Pull Request is ready to enter CI label May 14, 2021
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label May 14, 2021
@oJshua oJshua added the CI Pull Request is ready to enter CI label May 14, 2021
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label May 14, 2021
@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label May 14, 2021
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label May 14, 2021
@mergify
Copy link
Contributor

mergify bot commented May 14, 2021

automerge label removed due to a CI failure

@CriesofCarrots CriesofCarrots merged commit 7be3171 into solana-labs:master May 14, 2021
mergify bot added a commit that referenced this pull request May 15, 2021
* feat: update api urls

(cherry picked from commit 0f3045f)

* fix: cluster test

(cherry picked from commit ae5a10d)

* docs: update old devnet and testnet url references

(cherry picked from commit ec621e7)

* fix: update devnet and testnet urls

(cherry picked from commit 7be3171)

Co-authored-by: Josh Hundley <josh.hundley@gmail.com>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants