This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Optimize aligned memory used by the runtime #17324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raw results on master. serialize 78s with this change vs 108s without this change
|
1.6 looks good at first glance. I will work this into the graph. I ran jack's change twice to make sure it really was that fast:
|
confirmed that #17324, cherry-picked to v1.6, restores performance of replay. metrics spreadsheet for 1.6 updated |
jackcmay
force-pushed
the
optimize-aligned-memory
branch
from
May 19, 2021 16:29
c194697
to
4aa73b2
Compare
updated metrics spreadsheet for master. looks good |
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2021
(cherry picked from commit 477898f) # Conflicts: # cli/Cargo.toml # programs/bpf/Cargo.toml # programs/bpf_loader/Cargo.toml # programs/bpf_loader/src/syscalls.rs
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
AlignedMemory
implementation added a new and superfluousmemset
in cases where the data was later written incrementally (most pronounced in program parameter serialization). This is causing performance degradation.Summary of Changes
memset
, includes other optimizations utilized in other areas of the rbpf (and thus runtime)Fixes #