This repository was archived by the owner on Jan 22, 2025. It is now read-only.
removes manual trait impl for contact-info #17332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementations only use the id and disregard other fields, in particular wallclock. This can lead to bugs where an outdated contact-info shadows or overrides a current one because they compare equal.
Codecov Report
@@ Coverage Diff @@
## master #17332 +/- ##
=======================================
Coverage 82.6% 82.7%
=======================================
Files 423 423
Lines 118053 118037 -16
=======================================
+ Hits 97626 97649 +23
+ Misses 20427 20388 -39 |
CriesofCarrots
approved these changes
May 19, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2021
The current implementations use only the id and disregard other fields, in particular wallclock. This can lead to bugs where an outdated contact-info shadows or overrides a current one because they compare equal. (cherry picked from commit 13b032b)
mergify bot
added a commit
that referenced
this pull request
May 19, 2021
The current implementations use only the id and disregard other fields, in particular wallclock. This can lead to bugs where an outdated contact-info shadows or overrides a current one because they compare equal. (cherry picked from commit 13b032b) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementations only use the
idand disregard other fields,in particular
wallclock. This can lead to bugs where an outdatedcontact-info shadows or overrides a current one because they compare
equal.
Summary of Changes
Removed manual implementation in favor of derive macro.