This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Purge expired BlockHeight data from blockstore #17634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
|
Actually, we probably need to add it to |
yeah. lol. I was rushing too. xD |
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
|
@CriesofCarrots (I'm going to bed..) could you monitor this while bots back-port to v1.6 & v1.7? |
💯 I'll handle @ryoqun |
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
* Purge expired BlockHeight data from blockstore * Also call compact_storage and add comment.... (cherry picked from commit 96cdbfd) # Conflicts: # ledger/src/blockstore_db.rs
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
* Purge expired BlockHeight data from blockstore * Also call compact_storage and add comment.... (cherry picked from commit 96cdbfd) # Conflicts: # ledger/src/blockstore_db.rs
mergify bot
added a commit
that referenced
this pull request
Jun 2, 2021
) * Purge expired BlockHeight data from blockstore (#17634) * Purge expired BlockHeight data from blockstore * Also call compact_storage and add comment.... (cherry picked from commit 96cdbfd) # Conflicts: # ledger/src/blockstore_db.rs * Fix conflict Co-authored-by: Ryo Onodera <ryoqun@gmail.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
mergify bot
added a commit
that referenced
this pull request
Jun 2, 2021
) * Purge expired BlockHeight data from blockstore (#17634) * Purge expired BlockHeight data from blockstore * Also call compact_storage and add comment.... (cherry picked from commit 96cdbfd) # Conflicts: # ledger/src/blockstore_db.rs * Fix conflict Co-authored-by: Ryo Onodera <ryoqun@gmail.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
block_height cf's data is never removed.
Fortunately, storage impact should be very small.
Summary of Changes
Purge it correctly and add reminder comment to avoid future re-occurrence.
follow up to #17523