This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Rename ValidatorExit and move to sdk #17728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
Jun 4, 2021
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #17728 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 431 432 +1
Lines 120603 120608 +5
=========================================
- Hits 99853 99838 -15
- Misses 20750 20770 +20 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2021
(cherry picked from commit 3a647c4)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ValidatorExit isn't specific to a validator; it is a general coordinated exit facility that just happens to be used by the validator. No reason it needs to be tied to the core validator code.
Summary of Changes
Rename struct to
Exitand move to solana-sdk cratecc #17698 (comment)