This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Don't use pinned memory for gossip and repair responses #17832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
changed the title
sakridge
force-pushed
the
gossip-no-pinned
branch
2 times, most recently
from
87b91f0 to
8fea66e
Compare
behzadnouri
reviewed
Jun 8, 2021
|
(nice, definitely want a 1.7 backport. Maybe we don't want 1.6 just yet...) |
behzadnouri
reviewed
Jun 8, 2021
Reports of excessive GPU memory usage and errors from cudaHostRegister. There are some cases where pinning is not required.
sakridge
force-pushed
the
gossip-no-pinned
branch
from
8fea66e to
c2df65c
Compare
Codecov Report
@@ Coverage Diff @@
## master #17832 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 433 433
Lines 120681 120700 +19
=======================================
+ Hits 99901 99928 +27
+ Misses 20780 20772 -8 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
Reports of excessive GPU memory usage and errors from cudaHostRegister. There are some cases where pinning is not required. (cherry picked from commit eeee75c)
Closed
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Sep 12, 2021
…olana-labs#17934)" This reverts commit e2e41a2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reports of excessive GPU memory usage and errors from cudaHostRegister
Summary of Changes
Don't use pinned memory when unnecessary.
Fixes #17775 #17304