This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
use trait to simplify and consolidate cumulative code #17852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
changed the title
jeffwashington
force-pushed
the
cumulative3
branch
from
4d48d1d to
af2e970
Compare
jeffwashington
force-pushed
the
cumulative3
branch
from
af2e970 to
67b661a
Compare
Codecov Report
@@ Coverage Diff @@
## master #17852 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 429 429
Lines 120319 120323 +4
=======================================
+ Hits 99533 99538 +5
+ Misses 20786 20785 -1 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
(cherry picked from commit 2dc6969) # Conflicts: # runtime/src/accounts_hash.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 14, 2021
(cherry picked from commit 2dc6969) # Conflicts: # runtime/src/accounts_hash.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 15, 2021
(cherry picked from commit 2dc6969) # Conflicts: # runtime/src/accounts_hash.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
there were 2d and 1d versions of cumulative functions.
Summary of Changes
consolidate into a single code path.
Fixes #