This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Make account shrink configurable #17544 (backport #17778) #18013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
conflicts
automerge
Merge this Pull Request automatically once CI passes
labels
Jun 16, 2021
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Jun 16, 2021
jeffwashington
force-pushed
the
mergify/bp/v1.7/pr-17778
branch
from
June 16, 2021 23:44
3b9d1bb
to
c2722c2
Compare
mergify
bot
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Jun 16, 2021
@lijunwangs I had to manually merge this. Please verify that I did it correctly. |
lijunwangs
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
mergify
bot
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Jun 17, 2021
automerge label removed due to a CI failure |
mergify
bot
added
automerge
Merge this Pull Request automatically once CI passes
and removed
automerge
Merge this Pull Request automatically once CI passes
labels
Jun 17, 2021
automerge label removed due to a CI failure |
1. Added both options for measuring space usage using total accounts usage and for individual store shrink ratio using an enum. Validator CLI options: --accounts-shrink-optimize-total-space and --accounts-shrink-ratio 2. Added code for selecting candidates based on total usage in a separate function select_candidates_by_total_usage 3. Added unit tests for the new functions added 4. The default implementations is kept at 0.8 shrink ratio with --accounts-shrink-optimize-total-space set to true Fixes #17544 (cherry picked from commit 269d995) # Conflicts: # core/tests/snapshots.rs # ledger/src/bank_forks_utils.rs # runtime/src/accounts_db.rs # runtime/src/snapshot_utils.rs
jeffwashington
force-pushed
the
mergify/bp/v1.7/pr-17778
branch
from
June 17, 2021 15:42
c2722c2
to
22bbe87
Compare
mergify
bot
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Jun 17, 2021
Codecov Report
@@ Coverage Diff @@
## v1.7 #18013 +/- ##
========================================
Coverage 82.5% 82.5%
========================================
Files 432 432
Lines 120366 120565 +199
========================================
+ Hits 99304 99500 +196
- Misses 21062 21065 +3 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #17778 done by Mergify.
Cherry-pick of 269d995 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/