Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

move zero lamport list out of per-account for loop #18022

Closed
wants to merge 1 commit into from

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Jun 16, 2021

Problem

Account index insertion is the bottleneck on startup time.

Summary of Changes

Move code out of the per-account loop.
Fixes #

@jeffwashington
Copy link
Contributor Author

measurements show a 1% improvement. Not huge, but this code path is the limiting factor on startup time. Makes sense to move operations out of the critical path per-account loop as # accounts grows.

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@d99b8f1). Click here to learn what that means.
The diff coverage is 87.4%.

@@            Coverage Diff            @@
##             master   #18022   +/-   ##
=========================================
  Coverage          ?    82.6%           
=========================================
  Files             ?      435           
  Lines             ?   121592           
  Branches          ?        0           
=========================================
  Hits              ?   100440           
  Misses            ?    21152           
  Partials          ?        0           

@jeffwashington jeffwashington marked this pull request as ready for review June 17, 2021 15:38
@jeffwashington jeffwashington requested a review from sakridge June 17, 2021 15:39
@sakridge
Copy link
Contributor

This is removed by #17601 which is close to be ready to merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants