This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add additional subscription metrics #18071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
v1.6
automerge
Codecov Report
@@ Coverage Diff @@
## master #18071 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.1%
=========================================
Files 434 434
Lines 121236 121239 +3
=========================================
+ Hits 99856 99857 +1
- Misses 21380 21382 +2 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2021
(cherry picked from commit 83a6c66)
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2021
(cherry picked from commit 83a6c66)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pubsub dashboard reports number of notifications, but not number of subscriptions. We want to track number of subscriptions in order to trace memory usage on the nodes
Summary of Changes
On
check_subscription_count(), report number of subscriptions to metrics server. Also report number of subscription attempts refused due to limit.