Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

metric for accounts index insertion time #18202

Merged
merged 1 commit into from
Jun 25, 2021
Merged

metric for accounts index insertion time #18202

merged 1 commit into from
Jun 25, 2021

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Jun 24, 2021 •
edited
Loading

Problem

Insertion time for accounts index is a critical path.

Summary of Changes

add a metric for insertion time once we have a lock.
Fixes #

@jeffwashington jeffwashington requested a review from sakridge June 24, 2021 17:13
@jeffwashington jeffwashington marked this pull request as ready for review June 24, 2021 17:13
@jeffwashington
Copy link
Contributor Author 

generate_index total_us=30797587i scan_stores_us=12681202i insertion_time_us=28243551i

@jeffwashington jeffwashington requested a review from jbiseda June 24, 2021 17:40
sakridge
sakridge previously approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot dismissed sakridge’s stale review June 24, 2021 20:03

Pull request has been modified.

@jeffwashington
Copy link
Contributor Author

flaky test

@jeffwashington jeffwashington merged commit f2a2581 into solana-labs:master Jun 25, 2021
mergify bot pushed a commit that referenced this pull request Jun 25, 2021
@jeffwashington
metric for accounts index insertion time (#18202)
76abb6b 
(cherry picked from commit f2a2581)
@mergify mergify bot mentioned this pull request Jun 25, 2021
Merged
jeffwashington added a commit that referenced this pull request Jun 25, 2021
@mergify @jeffwashington
metric for accounts index insertion time (#18202) (#18226)
41179b1 
(cherry picked from commit f2a2581)

Co-authored-by: Jeff Washington (jwash) <75863576+jeffwashington@users.noreply.github.com>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sakridge sakridge sakridge left review comments

@jbiseda jbiseda Awaiting requested review from jbiseda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffwashington @sakridge