Unignore spl downstream build #18218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hold, pending |
We're still stuck on the borsh bump? |
Now that v1.7.4 has shipped, we should be able to upgrade SPL borsh and undraft this! I'll do that tomorrow |
|
Downstream borsh bump: solana-labs/solana-program-library#2015 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
CriesofCarrots
removed
the
stale
CriesofCarrots
force-pushed
the
unignore-spl-downstream
branch
from
18b763d
to
f411442
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
(cherry picked from commit 072a776)
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
(cherry picked from commit 072a776)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jul 12, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SPL downstream build was ignored due to breaking DefaultSigner changes. However, solana-labs/solana-program-library#1870 removed the DefaultSigner usage.
Summary of Changes
Unignore SPL downstream build