Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

refactor(rpc_client): const number of retries for send and confirm transaction #18390

Merged
merged 2 commits into from
Jul 5, 2021
Merged

refactor(rpc_client): const number of retries for send and confirm transaction #18390

merged 2 commits into from
Jul 5, 2021

Conversation

hrls
Copy link
Contributor

@hrls hrls commented Jul 2, 2021

Summary of Changes

RpcClient::send_and_confirm_transaction body was refactored for re-sending transaction after some number of failed attempts receiving previous transaction status. Currently number of retries is 1, so function do the same as the current one.

Based on #18389

@mergify mergify bot added the community Community contribution label Jul 2, 2021
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@5ca9753). Click here to learn what that means.
The diff coverage is 87.4%.

@@            Coverage Diff            @@
##             master   #18390   +/-   ##
=========================================
  Coverage          ?    82.3%           
=========================================
  Files             ?      435           
  Lines             ?   121409           
  Branches          ?        0           
=========================================
  Hits              ?    99999           
  Misses            ?    21410           
  Partials          ?        0           

Copy link
Contributor

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I realized that the logic for expiring a transaction here is wrong (predates your change), and wrote up #18426 about it. Would you be interested in fixing this up since you're already interested in improving this function? If not no big deal, I'll take care of it sometime

@mvines mvines added the v1.7 label Jul 5, 2021
@mvines mvines merged commit 70234df into solana-labs:master Jul 5, 2021
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
…ansaction (#18390)

* refactor(rpc_client): simplfy send and confirm transaction flow

* chore: configurable num of retries for send and confirm

(cherry picked from commit 70234df)
CriesofCarrots pushed a commit that referenced this pull request Jul 13, 2021
…ansaction (#18390)

* refactor(rpc_client): simplfy send and confirm transaction flow

* chore: configurable num of retries for send and confirm

(cherry picked from commit 70234df)
mergify bot added a commit that referenced this pull request Jul 13, 2021
…ansaction (#18390) (#18427)

* refactor(rpc_client): simplfy send and confirm transaction flow

* chore: configurable num of retries for send and confirm

(cherry picked from commit 70234df)

Co-authored-by: hrls <viktor.kharitonovich@gmail.com>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants