Cli: Support checked stake and vote operations

[CriesofCarrots]

Problem

New checked stake and vote instructions aren't exposed in the solana-cli

Summary of Changes

Add new checked subcommands

• Vote AuthorizeChecked
• Stake InitializeChecked
• Stake AuthorizeChecked
• Stake SetLockupChecked
• Integration tests
• Try with hardware wallet

Needs rebase on #18345

[CriesofCarrots]

I probably won't merge this until I get the Ledger work done and tested, but ready for review.
Incidentally, I think I would have preferred to add a --checked parameter to the affected commands instead of duplicate commands, but I wanted the help text to be very clear about the type of authority required (pubkey vs. keypair).

[mvines]

I probably won't merge this until I get the Ledger work done and tested, but ready for review.
Incidentally, I think I would have preferred to add a --checked parameter to the affected commands instead of duplicate commands, but I wanted the help text to be very clear about the type of authority required (pubkey vs. keypair).

Makes sense to me, I don't have a better suggestion. PR looks good to me overall as well

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[CriesofCarrots]

This changeset + hardware wallet signers = looks good

[codecov]

Codecov Report

Merging #18449 (c1299c4) into master (abe5a0a) will increase coverage by 0.0%.
The diff coverage is 88.1%.

@@           Coverage Diff            @@
##           master   #18449    +/-   ##
========================================
  Coverage    82.7%    82.7%            
========================================
  Files         438      438            
  Lines      123760   124276   +516     
========================================
+ Hits       102440   102879   +439     
- Misses      21320    21397    +77     

[t-nelson]

Looks great!

It's a shame clap doesn't support conditional arg validation. These could've been a --use-checked-instruction instead of new subcommands 🤕

[CriesofCarrots]

It's a shame clap doesn't support conditional arg validation. These could've been a --use-checked-instruction instead of new subcommands

Agreed, I even liked just a --checked flag.
But even with conditional arg validation, making useful help text for those PUBKEY or KEYPAIR args would be a bit of a bear, so oh well, hopefully clarity++