This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
serial insertion of bins into accounts index #18469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Accounts index generation is slow. Looks like we end up with too few items per bin to insert to be efficiently done in parallel. At 72M accounts, 400k slots, we end up with an average of ~11 accounts per bin per slot.
Summary of Changes
Rely on parallelism at storage level instead of within index generation. This can be tuned over time. We could collect multiple storages/slots together to reduce lock grabbing cost. We could chunk multiple bins into a thread and spin up something like 4 or 8 or 16 threads total instead of BINS (currently 16) threads per insert.
Fixes #