This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
persists repair-peers cache across repair service loops (backport #18400) #18483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The repair-peers cache is reset each time repair service loop runs, and so computed repeatedly for the same slots: https://github.com/solana-labs/solana/blob/d2b07dca9/core/src/repair_service.rs#L275 This commit uses an LRU cache to persists repair-peers for each slot. In addition to LRU eviction rules, in order to avoid re-using outdated data, each entry also has 10 seconds TTL. (cherry picked from commit a0551b4)
mergify
bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.7 #18483 +/- ##
=======================================
Coverage 82.2% 82.2%
=======================================
Files 431 431
Lines 121162 121176 +14
=======================================
+ Hits 99690 99713 +23
+ Misses 21472 21463 -9 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #18400 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/