Rocks db window utils #1851
Merged
Rocks db window utils #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
force-pushed
the
RocksDbWindowUtils
branch
3 times, most recently
from
e3a7dcc to
153ef83
Compare
rob-solana
reviewed
Nov 17, 2018
src/db_ledger.rs
Outdated
| self.get(db, &key) | ||
| } | ||
|
|
||
| pub fn put_on_slot_index( |
There was a problem hiding this comment.
is there a precedent for "on", my brain wants to see "by"...
There was a problem hiding this comment.
that is indeed much better xD
rob-solana
reviewed
Nov 17, 2018
src/db_window.rs
Outdated
| @@ -0,0 +1,583 @@ | |||
| //! The `window` module defines data structure for storing the tail of the ledger. | |||
There was a problem hiding this comment.
blast from the past
carllin
force-pushed
the
RocksDbWindowUtils
branch
2 times, most recently
from
3830112 to
e672864
Compare
carllin
force-pushed
the
RocksDbWindowUtils
branch
from
e672864 to
8321ef8
Compare
garious
approved these changes
Nov 19, 2018
rob-solana
approved these changes
Nov 19, 2018
|
@carllin, mvines is OoO this week. No need to wait for his review. |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 15.6.2 to 15.9.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need a separate set of window functions before replacing current window implementation with RocksDb implementation. @garious, we can replace RocksDb with a pure Rust implementation, but seeing as we've invested already in an initial implementation using RocksDb, we're interested in first seeing the performance of integrating these changes. (Integration PR is coming after this one gets merged)
Summary of Changes
Add a module for windowing functions based on RocksDb
Fixes #