This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
prevent excess allocation with AccountsIndexIterator #18605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18605 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 440 440
Lines 123885 123886 +1
=========================================
- Hits 102558 102509 -49
- Misses 21327 21377 +50 |
sakridge
approved these changes
Jul 13, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
(cherry picked from commit 0bd8710)
jeffwashington
added a commit
that referenced
this pull request
Jul 15, 2021
(cherry picked from commit 0bd8710)
jeffwashington
added a commit
that referenced
this pull request
Jul 19, 2021
(cherry picked from commit 0bd8710)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
accounts index iteration only wants
ITER_BATCH_SIZEitems. After previous refactorings, we could unnecessarily prepare many more items than required.Summary of Changes
Only accumulate
ITER_BATCH_SIZEitems.Fixes #