Cli configurable validators

[t-nelson]

Problem

solana validators can only return a filtered list of validators

Summary of Changes

• add config parameters for getVoteAccounts
• plumb them through CLI

[codecov]

Codecov Report

Merging #18630 (d612c5a) into master (74b29c0) will decrease coverage by 0.0%.
The diff coverage is 55.1%.

@@            Coverage Diff            @@
##           master   #18630     +/-   ##
=========================================
- Coverage    82.7%    82.7%   -0.1%     
=========================================
  Files         436      436             
  Lines      123485   123512     +27     
=========================================
- Hits       102192   102168     -24     
- Misses      21293    21344     +51     

[CriesofCarrots]

Code lgtm, one nit.
Concerned at all about the implications of variable delinquent slot distance for downstream tools (block explorers, validator stats, etc)? Or you figure that anyone assertive enough to use delinquent_slot_distance should expose that configuration to users in their product?

[t-nelson]

Code lgtm, one nit.
Concerned at all about the implications of variable delinquent slot distance for downstream tools (block explorers, validator stats, etc)? Or you figure that anyone assertive enough to use delinquent_slot_distance should expose that configuration to users in their product?

I'd like to think that no one would bother to expose it at all. This does remind me that I should update the docs though, so I'll put a warning there.

[mergify]

automerge label removed due to a CI failure

[CriesofCarrots]

I'd like to think that no one would bother to expose it at all

If "http://validator-website.com" is calling my node delinquent for being 20 slots behind, but my node looks fine on "http://validator-website-2.com" because they are using a threshold of 300 slots, I would want to know?

[t-nelson]

I'd like to think that no one would bother to expose it at all

If "http://validator-website.com" is calling my node delinquent for being 20 slots behind, but my node looks fine on "http://validator-website-2.com" because they are using a threshold of 300 slots, I would want to know?

Sorry, I misread that as expose as a knob to the user. I'd really like to think no one would pass it, period. The following note of discouragement was added with the docs update. Hopefully it's sufficient

solana/docs/src/developing/clients/jsonrpc-api.md

Line 3032 in 9ed1f24

- (optional) `delinquentSlotDistance: <u64>` - Specify the number of slots behind the tip that a validator must fall to be considered delinquent. **NOTE:** For the sake of consistency between ecosystem products, _it is **not** recommended that this argument be specified._